Uploaded image for project: 'PUBLIC - Liferay Portal Community Edition'
  1. PUBLIC - Liferay Portal Community Edition
  2. LPS-98437

Apply SF changes to LCS (7.0.x-private)

    Details

    • Type: Task
    • Status: Closed
    • Priority: Minor
    • Resolution: Completed
    • Affects Version/s: None
    • Fix Version/s: 7.0.X
    • Labels:
      None

      Description

      As requested here I'm creating this ticket to track the application of a branch-specific fix to 7.0.x-private.

      Motivation: this PR to the "master-private" branch had spurious source formatting problems reported because of formatting issues in the lcs/lcs-client-web module from the 7.0.x-private branch, which gets overlaid onto master-private when the working directory gets set up.

      In practice, we don't expect this kind of thing to be frequent because later "master-private" tooling does a better job of running only against changed files. Nevertheless, the "deep" fix of actually fixing the files on 7.0.x-private is easy (just run "npx liferay-npm-scripts format:check") and automated (ie. minimizing real risk of human error), so we might as well do it.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                brian.chan Brian Chan
                Reporter:
                greg.hurrell Greg Hurrell
                Recent user:
                Greg Hurrell
                Participants of an Issue:
                Engineering Assignee:
                Greg Hurrell
              • Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Packages

                  Version Package
                  7.0.X