Even if a user does not have "Calendar > Calendar: Permissions", "Permissions" button is displayed for "Edit Event"

• Type: Bug
• Status: Closed
• Resolution: Fixed
• Affects Version/s: 7.0.X, 7.1.X, 7.2.X, Master
• Fix Version/s: 7.0.0 DXP FP86, 7.0.X, 7.1.10 DXP FP13, 7.1.X, 7.2.10 DXP FP1, 7.2.X, 7.2.1 CE GA2, 7.3.10 DXP GA1, Master
• Component/s: Calendar
• Labels:
  • ee-ts
  • fw_code_review
  • liferay-fixpack-de-86-7010
  • liferay-fixpack-dxp-1-7210
  • liferay-fixpack-dxp-13-7110
• Branch Version/s:
  7.2.x, 7.1.x, 7.0.x
• Backported to Branch:
  Committed
• Fix Priority: 3
• Git Pull Request: https://github.com/brianchandotcom/liferay-portal/pull/76645

Steps to reproduce

1. Setup Liferay DXP7.0 and install DE-84
2. Login as [e-mail]
3. Add a calendar portlet to default page
4. Add a calendar event of the site
5. Navigate to Control Panel > Users > Roles > Site Roles
6. Define "Site Member" permission as the followings

   Calendar > Calendar: Delete Remove
   Calendar > Calendar: Manage Events
   Calendar > Calendar: Update Remove
   Calendar > Calendar: View Remove
   Calendar > Calendar: View Event

7. Navigate to Control Panel > Users > Users and Organizations
8. Add a user named "user1" and join default(Liferay DXP) site
9. Login as user1
10. Select the calendar event added in step 4 and click "Edit"
11. When the "Edit Event" screen is displayed, click "Permission" button

Actual result
Error message is displayed in the log:

2019-08-01 01:57:46.749 ERROR [http-nio-8080-exec-2][PortletConfigurationPortlet:667] User 31940 must have DEFINE_PERMISSIONS permission 

Expected result
"Permission" button is not displayed for users who do not have the permission.

Note
A unique fix will be required for 7.0.x due to the changes in how we check for permissions.