Uploaded image for project: 'PUBLIC - Liferay Portal Community Edition'
  1. PUBLIC - Liferay Portal Community Edition
  2. LPS-99525

portal-workflow-metrics-web files and possibly others should be using .es.js extension

    Details

    • Type: Task
    • Status: Open
    • Priority: Minor
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: None
    • Labels:
      None

      Description

      I noticed while preparing https://github.com/brianchandotcom/liferay-portal-ee/pull/25877 that there were some files inside the portal-workflow-metrics-web project that contain "React.Fragment" elements which I would have expected our linter to detect and auto-fix to use shorthand ("<>"/"</>") instead.

      The cause is that the files in question use a ".js" extension, which is why the linter doesn't check them (the linter considers any ".js" file that is not an ".es.js" file to be "legacy" and not to be touched).

      It seems these files should be renamed to use the ".es.js" extension and we should address any lints that come up as a result. Either that, or switch "master-private" to lint all ".js" files; for reference, the rough file counts are as follows:

      find //{src,test} -name '.js' -not -name '.es.js' | wc -l
      {{ 177}}
      apps ❯ find //{src,test} -name '*.es.js' | wc -l
      {{ 8}}

        Attachments

          Activity

            People

            • Assignee:
              support-lep@liferay.com SE Support
              Reporter:
              greg.hurrell Greg Hurrell
              Recent user:
              Greg Hurrell
              Participants of an Issue:
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:

                Packages

                Version Package