PUBLIC - Liferay Portal Community Edition
  1. PUBLIC - Liferay Portal Community Edition
  2. LPS-9955

Encode wiki links so that special characters can be used in JSPWiki content

    Details

    • Branch Version/s:
      6.0.x
    • Similar Issues:
      Show 5 results 

      Description

      Currently there are many characters that are not valid for use in the Wiki title. A big reason is due to the way JSP Wiki handles wiki links in its content. By encoding wiki links before JSP Wiki is given the content, we can provide the ability to use more characters in the wiki title.

      Note: Tomcat needs a property to be set before an encoded forward slash is allowed to be used in the URL. If this is a character that is going to be used, set this property:

      -Dorg.apache.tomcat.util.buf.UDecoder.ALLOW_ENCODED_SLASH=true

        Issue Links

          Activity

          Hide
          Brian Chan added a comment -

          Hey Doug,

          I made changes in 54197 in case you decide to backport this. Thx.

          Show
          Brian Chan added a comment - Hey Doug, I made changes in 54197 in case you decide to backport this. Thx.
          Hide
          Douglas Wong added a comment -

          Unless I'm told otherwise, we're not planning to backport this because it's considered an improvement.

          Show
          Douglas Wong added a comment - Unless I'm told otherwise, we're not planning to backport this because it's considered an improvement.
          Hide
          Raymond Auge added a comment -

          You need to add the title regex validation change to the verifiers since it leaves data in the DB that no longer validates.

          Show
          Raymond Auge added a comment - You need to add the title regex validation change to the verifiers since it leaves data in the DB that no longer validates.
          Hide
          Douglas Wong added a comment -

          Hey John,

          I did not make % a valid character, so that's why you may have trouble with that. Here's a list of characters that should be valid ' @ ^ ! ` ? / *

          Show
          Douglas Wong added a comment - Hey John, I did not make % a valid character, so that's why you may have trouble with that. Here's a list of characters that should be valid ' @ ^ ! ` ? / *
          Hide
          Brian Chan added a comment -

          I just rolled this back because it causes the syntax [[http://liferay.com | Liferay.com]] to no longer work

          That happens because http:// gets cahnged to http:SLASLA which is the Creole interpreter doesn't understand.

          Show
          Brian Chan added a comment - I just rolled this back because it causes the syntax [ [http://liferay.com | Liferay.com] ] to no longer work That happens because http:// gets cahnged to http: SLA SLA which is the Creole interpreter doesn't understand.
          Hide
          Douglas Wong added a comment -

          This ticket is the cause of LPS-10202 and LPS-11598. Recommitting with these issues fixed.

          Show
          Douglas Wong added a comment - This ticket is the cause of LPS-10202 and LPS-11598 . Recommitting with these issues fixed.
          Hide
          Robert Srisam-ang (Inactive) added a comment -

          Tested in the following environments:

          Tomcat 6.0.26 + MySQL 5. Firefox 3.6.16. Trunk Revision 54175.
          Tomcat 6.0.29 + MySQL 5. Firefox 3.6.16. Trunk Revision 78782.

          After testing both the older and newer revisions, wiki titles now except more special characters (' @ ^ ! ` ? / * &). Links in wiki content also work properly. Passed Manual Testing.

          Show
          Robert Srisam-ang (Inactive) added a comment - Tested in the following environments: Tomcat 6.0.26 + MySQL 5. Firefox 3.6.16. Trunk Revision 54175. Tomcat 6.0.29 + MySQL 5. Firefox 3.6.16. Trunk Revision 78782. After testing both the older and newer revisions, wiki titles now except more special characters (' @ ^ ! ` ? / * &). Links in wiki content also work properly. Passed Manual Testing.

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Days since last comment:
                4 years, 5 weeks, 3 days ago

                Development

                  Structure Helper Panel