Uploaded image for project: 'PUBLIC - Liferay Portal Community Edition'
  1. PUBLIC - Liferay Portal Community Edition
  2. LPS-9955

Encode wiki links so that special characters can be used in JSPWiki content

    Details

    • Branch Version/s:
      6.0.x
    • Similar Issues:
      Show 5 results 

      Description

      Currently there are many characters that are not valid for use in the Wiki title. A big reason is due to the way JSP Wiki handles wiki links in its content. By encoding wiki links before JSP Wiki is given the content, we can provide the ability to use more characters in the wiki title.

      Note: Tomcat needs a property to be set before an encoded forward slash is allowed to be used in the URL. If this is a character that is going to be used, set this property:

      -Dorg.apache.tomcat.util.buf.UDecoder.ALLOW_ENCODED_SLASH=true

        Issue Links

          Activity

          douglas.wong Douglas Wong created issue -
          douglas.wong Douglas Wong made changes -
          Field Original Value New Value
          Link This issue is related to LPS-4498 [ LPS-4498 ]
          douglas.wong Douglas Wong made changes -
          Status Open [ 1 ] In Progress [ 3 ]
          douglas.wong Douglas Wong made changes -
          Status In Progress [ 3 ] In Review [ 10006 ]
          brian.chan Brian Chan made changes -
          Affects Version/s 6.0.1 RC [ 10502 ]
          brian.chan Brian Chan made changes -
          Status In Review [ 10006 ] Closed [ 6 ]
          Resolution Fixed [ 1 ]
          Hide
          brian.chan Brian Chan added a comment -

          Hey Doug,

          I made changes in 54197 in case you decide to backport this. Thx.

          Show
          brian.chan Brian Chan added a comment - Hey Doug, I made changes in 54197 in case you decide to backport this. Thx.
          Hide
          douglas.wong Douglas Wong added a comment -

          Unless I'm told otherwise, we're not planning to backport this because it's considered an improvement.

          Show
          douglas.wong Douglas Wong added a comment - Unless I'm told otherwise, we're not planning to backport this because it's considered an improvement.
          Hide
          rotty Raymond Auge added a comment -

          You need to add the title regex validation change to the verifiers since it leaves data in the DB that no longer validates.

          Show
          rotty Raymond Auge added a comment - You need to add the title regex validation change to the verifiers since it leaves data in the DB that no longer validates.
          rotty Raymond Auge made changes -
          Resolution Fixed [ 1 ]
          Status Closed [ 6 ] Reopened [ 4 ]
          douglas.wong Douglas Wong made changes -
          Fix Version/s --Sprint - 06/10 [ 10610 ]
          Fix Version/s 6.0.2 RC [ 10524 ]
          douglas.wong Douglas Wong made changes -
          Status Reopened [ 4 ] In Progress [ 3 ]
          douglas.wong Douglas Wong made changes -
          Status In Progress [ 3 ] In Review [ 10006 ]
          cynthia.wilburn Cynthia Wilburn (Inactive) made changes -
          Fix Version/s 6.0.3 GA [ 10612 ]
          cynthia.wilburn Cynthia Wilburn (Inactive) made changes -
          Fix Version/s --Sprint - SP [ 10611 ]
          Fix Version/s --Sprint - 06/10 [ 10610 ]
          Fix Version/s 6.0.3 GA [ 10612 ]
          cynthia.wilburn Cynthia Wilburn (Inactive) made changes -
          Fix Version/s 6.0.3 GA [ 10612 ]
          douglas.wong Douglas Wong made changes -
          Fix Version/s --Sprint - SP [ 10611 ]
          douglas.wong Douglas Wong made changes -
          Status In Review [ 10006 ] Closed [ 6 ]
          Resolution Fixed [ 1 ]
          cynthia.wilburn Cynthia Wilburn (Inactive) made changes -
          Resolution Fixed [ 1 ]
          Status Closed [ 6 ] Reopened [ 4 ]
          Assignee Douglas Wong [ douglas.wong ] Cynthia Wilburn [ cynthia.wilburn ]
          cynthia.wilburn Cynthia Wilburn (Inactive) made changes -
          Status Reopened [ 4 ] In Progress [ 3 ]
          cynthia.wilburn Cynthia Wilburn (Inactive) made changes -
          Status In Progress [ 3 ] In Review [ 10006 ]
          cynthia.wilburn Cynthia Wilburn (Inactive) made changes -
          Status In Review [ 10006 ] Manual Testing [ 10007 ]
          Assignee Cynthia Wilburn [ cynthia.wilburn ] Support QA [ support-qa ]
          Fix Version/s --Sprint - 06/10 [ 10610 ]
          Fix Version/s 6.0.3 GA [ 10612 ]
          douglas.wong Douglas Wong made changes -
          Link This issue relates LPS-6105 [ LPS-6105 ]
          michael.saechang Michael Saechang made changes -
          Assignee Support QA [ support-qa ] Michael Saechang [ michael.saechang ]
          michael.saechang Michael Saechang made changes -
          Assignee Michael Saechang [ michael.saechang ] EE Support [ support-ee ]
          samuel.kong Samuel Kong made changes -
          Assignee EE Support [ support-ee ] John Wayne Jiang [ john.jiang ]
          cynthia.wilburn Cynthia Wilburn (Inactive) made changes -
          Fix Version/s --Sprint - 07/10 [ 10613 ]
          Fix Version/s --Sprint - 06/10 [ 10610 ]
          Hide
          douglas.wong Douglas Wong added a comment -

          Hey John,

          I did not make % a valid character, so that's why you may have trouble with that. Here's a list of characters that should be valid ' @ ^ ! ` ? / *

          Show
          douglas.wong Douglas Wong added a comment - Hey John, I did not make % a valid character, so that's why you may have trouble with that. Here's a list of characters that should be valid ' @ ^ ! ` ? / *
          john.jiang John Wayne Jiang (Inactive) made changes -
          Status Manual Testing [ 10007 ] Resolved [ 5 ]
          Resolution Fixed [ 1 ]
          cynthia.wilburn Cynthia Wilburn (Inactive) made changes -
          Fix Version/s 6.1.0 [ 10550 ]
          Hide
          brian.chan Brian Chan added a comment -

          I just rolled this back because it causes the syntax [[http://liferay.com | Liferay.com]] to no longer work

          That happens because http:// gets cahnged to http:SLASLA which is the Creole interpreter doesn't understand.

          Show
          brian.chan Brian Chan added a comment - I just rolled this back because it causes the syntax [ [http://liferay.com | Liferay.com] ] to no longer work That happens because http:// gets cahnged to http: SLA SLA which is the Creole interpreter doesn't understand.
          cynthia.wilburn Cynthia Wilburn (Inactive) made changes -
          Fix Version/s --Sprint - 07/10_a [ 10613 ]
          douglas.wong Douglas Wong made changes -
          Link This issue relates LPS-10202 [ LPS-10202 ]
          douglas.wong Douglas Wong made changes -
          Link This issue relates LPS-11598 [ LPS-11598 ]
          douglas.wong Douglas Wong made changes -
          Resolution Fixed [ 1 ]
          Status Resolved [ 5 ] Reopened [ 4 ]
          Assignee John Wayne Jiang [ john.jiang ] Douglas Wong [ douglas.wong ]
          Hide
          douglas.wong Douglas Wong added a comment -

          This ticket is the cause of LPS-10202 and LPS-11598. Recommitting with these issues fixed.

          Show
          douglas.wong Douglas Wong added a comment - This ticket is the cause of LPS-10202 and LPS-11598 . Recommitting with these issues fixed.
          douglas.wong Douglas Wong made changes -
          Status Reopened [ 4 ] In Progress [ 3 ]
          douglas.wong Douglas Wong made changes -
          Backport Version/s [6.0.x]
          douglas.wong Douglas Wong made changes -
          Status In Progress [ 3 ] In Review [ 10006 ]
          cynthia.wilburn Cynthia Wilburn (Inactive) made changes -
          Fix Version/s --Sprint - SP [ 10628 ]
          cynthia.wilburn Cynthia Wilburn (Inactive) made changes -
          Fix Version/s 6.1.X [ 10655 ]
          cynthia.wilburn Cynthia Wilburn (Inactive) made changes -
          Link This issue relates LPS-12876 [ LPS-12876 ]
          cynthia.wilburn Cynthia Wilburn (Inactive) made changes -
          Fix Version/s 6.0.12 EE [ 10755 ]
          Fix Version/s --Sprint - SP [ 10628 ]
          cynthia.wilburn Cynthia Wilburn (Inactive) made changes -
          Status In Review [ 10006 ] Manual Testing [ 10007 ]
          michael.saechang Michael Saechang made changes -
          Labels QA-R
          robert.srisamang Robert Srisam-ang (Inactive) made changes -
          Assignee Douglas Wong [ douglas.wong ] Robert Srisamang [ robert.srisamang ]
          Hide
          robert.srisamang Robert Srisam-ang (Inactive) added a comment -

          Tested in the following environments:

          Tomcat 6.0.26 + MySQL 5. Firefox 3.6.16. Trunk Revision 54175.
          Tomcat 6.0.29 + MySQL 5. Firefox 3.6.16. Trunk Revision 78782.

          After testing both the older and newer revisions, wiki titles now except more special characters (' @ ^ ! ` ? / * &). Links in wiki content also work properly. Passed Manual Testing.

          Show
          robert.srisamang Robert Srisam-ang (Inactive) added a comment - Tested in the following environments: Tomcat 6.0.26 + MySQL 5. Firefox 3.6.16. Trunk Revision 54175. Tomcat 6.0.29 + MySQL 5. Firefox 3.6.16. Trunk Revision 78782. After testing both the older and newer revisions, wiki titles now except more special characters (' @ ^ ! ` ? / * &). Links in wiki content also work properly. Passed Manual Testing.
          robert.srisamang Robert Srisam-ang (Inactive) made changes -
          Status Manual Testing [ 10007 ] Resolved [ 5 ]
          Resolution Fixed [ 1 ]
          vicki.tsang Vicki Tsang (Inactive) made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          vicki.tsang Vicki Tsang (Inactive) made changes -
          Workflow Liferay Workflow 2.2 [ 230175 ] LPS Workflow [ 274564 ]
          andrew.kim Andrew Kim made changes -
          Workflow LPS Workflow [ 274564 ] Restricted LPS Workflow [ 381828 ]
          andrew.kim Andrew Kim made changes -
          Workflow Restricted LPS Workflow [ 381828 ] Copy of LPS Workflow [ 417408 ]
          andrew.kim Andrew Kim made changes -
          Workflow Copy of LPS Workflow [ 417408 ] LPS Workflow [ 449018 ]
          andrew.kim Andrew Kim made changes -
          Workflow LPS Workflow [ 449018 ] Copy 2 of LPS Workflow [ 481368 ]
          andrew.kim Andrew Kim made changes -
          Workflow Copy 2 of LPS Workflow [ 481368 ] LPS Workflow [ 513264 ]
          randy.zhu Randy Zhu (Inactive) made changes -
          Workflow LPS Workflow [ 513264 ] PUBLIC - LPS Generic Workflow [ 565046 ]
          randy.zhu Randy Zhu (Inactive) made changes -
          Workflow PUBLIC - LPS Generic Workflow [ 565046 ] Copy of PUBLIC - LPS Generic Workflow [ 599378 ]
          randy.zhu Randy Zhu (Inactive) made changes -
          Workflow Copy of PUBLIC - LPS Generic Workflow [ 599378 ] PUBLIC - LPS Generic Workflow [ 631307 ]
          randy.zhu Randy Zhu (Inactive) made changes -
          Component/s Collaboration [ 14506 ]
          randy.zhu Randy Zhu (Inactive) made changes -
          Issue Type Improvement [ 4 ] Bug [ 1 ]
          Assignee Robert Srisamang [ robert.srisamang ] SE Support [ support-lep@liferay.com ]
          randy.zhu Randy Zhu (Inactive) made changes -
          Workflow PUBLIC - LPS Generic Workflow [ 631307 ] PUBLIC - LPS General Workflow [ 725030 ]
          randy.zhu Randy Zhu (Inactive) made changes -
          Workflow PUBLIC - LPS General Workflow [ 725030 ] PUBLIC - LPS Bugs Workflow [ 822345 ]
          Transition Time In Source Status Execution Times Last Executer Last Execution Date
          Open Open In Progress In Progress
          2m 15s 1 Douglas Wong 28/May/10 6:50 PM
          In Review In Review Closed Closed
          5d 16h 9m 2 Douglas Wong 08/Jun/10 3:49 PM
          Closed Closed Reopened Reopened
          4d 22h 36m 2 Cynthia Wilburn (Inactive) 08/Jun/10 4:08 PM
          Resolved Resolved Reopened Reopened
          26d 14h 32m 1 Douglas Wong 04/Aug/10 1:54 PM
          Reopened Reopened In Progress In Progress
          6h 50m 3 Douglas Wong 04/Aug/10 2:14 PM
          In Progress In Progress In Review In Review
          31s 4 Douglas Wong 04/Aug/10 2:14 PM
          In Review In Review Manual Testing Manual Testing
          254d 2h 21m 2 Cynthia Wilburn (Inactive) 15/Apr/11 4:36 PM
          Manual Testing Manual Testing Resolved Resolved
          36d 7h 23m 2 Robert Srisam-ang (Inactive) 21/Apr/11 4:46 PM
          Resolved Resolved Closed Closed
          199d 6h 21m 1 Vicki Tsang (Inactive) 06/Nov/11 10:07 PM

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Days since last comment:
                5 years, 6 weeks ago

                Development

                  Subcomponents

                    Structure Helper Panel