Details

    • Branch Version/s:
      6.1.x
    • Backported to Branch:
      Committed
    • Epic/Theme:
    • Fix Priority:
      4
    • Liferay Contributor's Agreement:
      Accept
    • Similar Issues:
      Show 4 results 

      Description

      Steps to reproduce:
      (1) obtain SO 1.6 bundle (or any version before 2.0.2) with some dedicated database (not Hypersonic)
      (2) start up SO 1.6
      (3) create a SO site
      (4) on the site /home page, edit the Welcome portlet (through Configuration), using the rich editor, fill in some text and / or image (exact content does not play any role)
      (5) shutdown SO 1.6
      (6) obtain newest SO 2.0 bundle (version 2.0.2 or later) and set it up to point to the 1.6 database, so that the upgrade is triggered
      (7) start up SO 2.0
      (8) watch the logs and confirm that "Upgrading com.liferay.so.hook.upgrade.v2_0_2.UpgradeGroup" is present

      Result:
      The Welcome portlet in upgraded SO 2.0 site is missing its previous content and renders as empty.

      Expected result:
      Welcome portlet content will persist after the upgrade to 2.0.2 or later.

      Details:
      SO 1.6 and also 2.0 contain Welcome portlet on each home page of SO-enabled site. This Welcome portlet is a WYSIWYG portlet from wysiwyg-portlet ("1_WAR_wysiwygportlet" in 1.6, "1_WAR_wysiwygportlet_INSTANCE_abcd" in 2.0, since the WYSIWYG portlet was made instanceable). It stores the presented HTML into its portlet-preferences, under key "message".

      v2_0_2.UpgradeGroup upgrades each 1.6 group using these steps:
      (1) deletes all layouts in the group;
      (2) merges (creates) new layouts from the new SO 2.0 layoutTemplate;

      This causes all portlet-preferences of old portlets to be removed. This is most visible for the welcome portlet, since it stored all its content in portlet-preferences. I'm not sure whether this is a bug or more an improvement.

        Activity

        Hide
        Josef Šustáček added a comment - - edited

        Possible solution is to update the v2_0_2.UpgradeGroup to store the old PorltetPreferences of "/home" of each group, then proceed as before and after new layouts are in place, copy PortletPreferences to new portlets (at least to the "1_WAR_wysiwygportlet_INSTANCE_abcd" and its "message" key).

        Show
        Josef Šustáček added a comment - - edited Possible solution is to update the v2_0_2.UpgradeGroup to store the old PorltetPreferences of "/home" of each group, then proceed as before and after new layouts are in place, copy PortletPreferences to new portlets (at least to the "1_WAR_wysiwygportlet_INSTANCE_abcd" and its "message" key).
        Hide
        Ken Duenwald added a comment -

        FAILED Manual Testing following the steps in the description.

        Reproduced on:
        Tomcat 7.0.27 + MySQL 5. Portal 6.1.20 EE GA2.
        Plugins 6.1.x EE GIT ID: 6bc7a5c97547f5af260f47aba04f63af574ddb55.

        "Upgrading com.liferay.so.hook.upgrade.v2_0_2.UpgradeGroup" shows up and the Welcome page shows nothing after step 8

        Failed on:
        Tomcat 7.0.27 + MySQL 5. Portal 6.1.20 EE GA2.
        Plugins 6.1.x EE GIT ID: 7f78e2c9aa43d8064614f0f76575af5069e8fb3a.
        Tomcat 7.0.27 + MySQL 5. Portal 6.1.x EE GIT ID: 6373fa1fd695b23f69e0bf980ef3fd7b7ad26584.
        Plugins 6.1.x EE GIT ID: 7f78e2c9aa43d8064614f0f76575af5069e8fb3a.

        "Upgrading com.liferay.so.hook.upgrade.v2_0_2.UpgradeGroup" still shows up and the Welcome page still shows nothing after step 8

        Show
        Ken Duenwald added a comment - FAILED Manual Testing following the steps in the description. Reproduced on: Tomcat 7.0.27 + MySQL 5. Portal 6.1.20 EE GA2. Plugins 6.1.x EE GIT ID: 6bc7a5c97547f5af260f47aba04f63af574ddb55. "Upgrading com.liferay.so.hook.upgrade.v2_0_2.UpgradeGroup" shows up and the Welcome page shows nothing after step 8 Failed on: Tomcat 7.0.27 + MySQL 5. Portal 6.1.20 EE GA2. Plugins 6.1.x EE GIT ID: 7f78e2c9aa43d8064614f0f76575af5069e8fb3a. Tomcat 7.0.27 + MySQL 5. Portal 6.1.x EE GIT ID: 6373fa1fd695b23f69e0bf980ef3fd7b7ad26584. Plugins 6.1.x EE GIT ID: 7f78e2c9aa43d8064614f0f76575af5069e8fb3a. "Upgrading com.liferay.so.hook.upgrade.v2_0_2.UpgradeGroup" still shows up and the Welcome page still shows nothing after step 8
        Hide
        Ken Duenwald added a comment -

        FAILED Manual Testing following the steps in the description.

        Failed on:
        Tomcat 7.0.27 + MySQL 5. Portal 6.1.20 EE GA2.
        Plugins 6.1.x EE GIT ID: a0711428695d284a49fb0fee58454c26a347bf9c.
        Tomcat 7.0.27 + MySQL 5. Portal 6.1.x EE GIT ID: c02312dc46a76cd2381adb98693e8485293772a7.
        Plugins 6.1.x EE GIT ID: a0711428695d284a49fb0fee58454c26a347bf9c.

        "Upgrading com.liferay.so.hook.upgrade.v2_0_2.UpgradeGroup" still shows up and the Welcome page still shows nothing after step 8

        Show
        Ken Duenwald added a comment - FAILED Manual Testing following the steps in the description. Failed on: Tomcat 7.0.27 + MySQL 5. Portal 6.1.20 EE GA2. Plugins 6.1.x EE GIT ID: a0711428695d284a49fb0fee58454c26a347bf9c. Tomcat 7.0.27 + MySQL 5. Portal 6.1.x EE GIT ID: c02312dc46a76cd2381adb98693e8485293772a7. Plugins 6.1.x EE GIT ID: a0711428695d284a49fb0fee58454c26a347bf9c. "Upgrading com.liferay.so.hook.upgrade.v2_0_2.UpgradeGroup" still shows up and the Welcome page still shows nothing after step 8
        Hide
        Ken Duenwald added a comment - - edited

        PASSED Manual Testing following the steps in the description.

        Passed on:
        Tomcat 7.0.27 + MySQL 5. Portal 6.1.20 EE GA2.
        Plugins 6.1.x EE GIT ID: cd17e53fd4d01d0076e3a4e0ce6ea0fdd6caaf90.

        Welcome Portlet content is now visible on upgrade, despite "Upgrading com.liferay.so.hook.upgrade.v2_0_2.UpgradeGroup" still being visible

        Show
        Ken Duenwald added a comment - - edited PASSED Manual Testing following the steps in the description. Passed on: Tomcat 7.0.27 + MySQL 5. Portal 6.1.20 EE GA2. Plugins 6.1.x EE GIT ID: cd17e53fd4d01d0076e3a4e0ce6ea0fdd6caaf90. Welcome Portlet content is now visible on upgrade, despite "Upgrading com.liferay.so.hook.upgrade.v2_0_2.UpgradeGroup" still being visible

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:
              Date of First Response:
              Days since last comment:
              2 years, 28 weeks, 2 days ago

              Development

                Structure Helper Panel