SO-Hook wont deploy when there's a portal instance

• Type: Regression Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.1.X CE, 2.1.X EE, 2.0.5 EE
• Fix Version/s: 2.1.X CE, 2.1.0 EE GA3
• Component/s: Administration (Control Panel)
• Labels:
  • SO_6.1.20_PASS
  • SO_6.1.30_PASS
  • SO_CE_UT
• Environment:
  Hide

  Tomcat 7.0.40 + MySQL 5. Portal 6.1.30 EE GIT ID: 009a56d4f746338e50b49eb6c4e944eefdb96720. ; Plugins 6.1.20 EE GIT ID: ae4afffa58f8509c04ad64de1f978f6daaa8b42d.; ; Tomcat 7.0.40 + MySQL 5. Portal 6.1.x EE GIT ID: 81bf916b461b5475b17faf4c56660632c79b696a. ; Plugins 6.1.x EE GIT ID: 950bc43a1ad0ab4c233e13c16612a27964bc8142.

  Show

  Tomcat 7.0.40 + MySQL 5. Portal 6.1.30 EE GIT ID: 009a56d4f746338e50b49eb6c4e944eefdb96720. Plugins 6.1.20 EE GIT ID: ae4afffa58f8509c04ad64de1f978f6daaa8b42d. Tomcat 7.0.40 + MySQL 5. Portal 6.1.x EE GIT ID: 81bf916b461b5475b17faf4c56660632c79b696a. Plugins 6.1.x EE GIT ID: 950bc43a1ad0ab4c233e13c16612a27964bc8142.
• Flagged:
  Impediment
• Fix Priority: 5

SO-Hook wont deploy when there's a portal instance

1. Start portal
2. Control Panel > Portal Instance > Add
   • www.able.com
3. Deploy SO Plugins

System display console error

21:53:32,131 ERROR [localhost-startStop-3][HotDeployImpl:198] com.liferay.portal.kernel.deploy.hot.HotDeployException: Error registering hook for so-hook
com.liferay.portal.kernel.deploy.hot.HotDeployException: Error registering hook for so-hook
        at com.liferay.portal.kernel.deploy.hot.BaseHotDeployListener.throwHotDeployException(BaseHotDeployListener.java:46)
        at com.liferay.portal.deploy.hot.HookHotDeployListener.invokeDeploy(HookHotDeployListener.java:277)
        at com.liferay.portal.deploy.hot.HotDeployImpl.doFireDeployEvent(HotDeployImpl.java:195)
        at com.liferay.portal.deploy.hot.HotDeployImpl.doFireDeployEvent(HotDeployImpl.java:222)
        at com.liferay.portal.deploy.hot.HotDeployImpl.fireDeployEvent(HotDeployImpl.java:97)
        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
        at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        at java.lang.reflect.Method.invoke(Method.java:601)
        at com.liferay.portal.security.lang.DoPrivilegedHandler.doInvoke(DoPrivilegedHandler.java:88)
        at com.liferay.portal.security.lang.DoPrivilegedHandler.invoke(DoPrivilegedHandler.java:56)
        at $Proxy29.fireDeployEvent(Unknown Source)
        at com.liferay.portal.kernel.deploy.hot.HotDeployUtil.fireDeployEvent(HotDeployUtil.java:27)
        at com.liferay.portal.kernel.servlet.PluginContextListener.fireDeployEvent(PluginContextListener.java:164)
        at com.liferay.portal.kernel.servlet.PluginContextListener.doPortalInit(PluginContextListener.java:154)
        at com.liferay.portal.kernel.util.BasePortalLifecycle.portalInit(BasePortalLifecycle.java:44)
        at com.liferay.portal.kernel.util.PortalLifecycleUtil.register(PortalLifecycleUtil.java:64)
        at com.liferay.portal.kernel.util.PortalLifecycleUtil.register(PortalLifecycleUtil.java:56)
        at com.liferay.portal.kernel.util.BasePortalLifecycle.registerPortalLifecycle(BasePortalLifecycle.java:54)
        at com.liferay.portal.kernel.servlet.PluginContextListener.contextInitialized(PluginContextListener.java:116)
        at org.apache.catalina.core.StandardContext.listenerStart(StandardContext.java:4887)
        at org.apache.catalina.core.StandardContext.startInternal(StandardContext.java:5381)
        at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:150)
        at org.apache.catalina.core.ContainerBase.addChildInternal(ContainerBase.java:901)
        at org.apache.catalina.core.ContainerBase.addChild(ContainerBase.java:877)
        at org.apache.catalina.core.StandardHost.addChild(StandardHost.java:633)
        at org.apache.catalina.startup.HostConfig.deployDirectory(HostConfig.java:1114)
        at org.apache.catalina.startup.HostConfig$DeployDirectory.run(HostConfig.java:1672)
        at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)
        at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:334)
        at java.util.concurrent.FutureTask.run(FutureTask.java:166)
        at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1110)
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:603)
        at java.lang.Thread.run(Thread.java:722)
Caused by: com.liferay.portal.kernel.upgrade.UpgradeException: com.liferay.portal.kernel.upgrade.UpgradeException: com.liferay.portal.NoSuchLayoutException: No Layout exists with the key {groupId=23, privateLayout=true, layoutId=3}
        at com.liferay.portal.kernel.upgrade.UpgradeProcess.upgrade(UpgradeProcess.java:181)
        at com.liferay.portal.upgrade.UpgradeProcessUtil._upgradeProcess(UpgradeProcessUtil.java:113)
        at com.liferay.portal.upgrade.UpgradeProcessUtil.upgradeProcess(UpgradeProcessUtil.java:66)
        at com.liferay.portal.deploy.hot.HookHotDeployListener.updateRelease(HookHotDeployListener.java:2419)
        at com.liferay.portal.deploy.hot.HookHotDeployListener.initPortalProperties(HookHotDeployListener.java:1913)
        at com.liferay.portal.deploy.hot.HookHotDeployListener.initPortalProperties(HookHotDeployListener.java:1551)
        at com.liferay.portal.deploy.hot.HookHotDeployListener.doInvokeDeploy(HookHotDeployListener.java:595)
        at com.liferay.portal.deploy.hot.HookHotDeployListener.invokeDeploy(HookHotDeployListener.java:274)
        ... 32 more
Caused by: com.liferay.portal.kernel.upgrade.UpgradeException: com.liferay.portal.NoSuchLayoutException: No Layout exists with the key {groupId=23, privateLayout=true, layoutId=3}
        at com.liferay.portal.kernel.upgrade.UpgradeProcess.upgrade(UpgradeProcess.java:181)
        at com.liferay.portal.kernel.upgrade.UpgradeProcess.upgrade(UpgradeProcess.java:195)
        at com.liferay.so.hook.upgrade.UpgradeProcess_2_0_0.doUpgrade(UpgradeProcess_2_0_0.java:41)
        at com.liferay.portal.kernel.upgrade.UpgradeProcess.upgrade(UpgradeProcess.java:178)
        ... 39 more
Caused by: com.liferay.portal.NoSuchLayoutException: No Layout exists with the key {groupId=23, privateLayout=true, layoutId=3}
        at com.liferay.portal.service.persistence.LayoutPersistenceImpl.findByG_P_L(LayoutPersistenceImpl.java:4514)
        at sun.reflect.GeneratedMethodAccessor563.invoke(Unknown Source)
        at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        at java.lang.reflect.Method.invoke(Method.java:601)
        at com.liferay.portal.security.lang.DoPrivilegedHandler.doInvoke(DoPrivilegedHandler.java:88)
        at com.liferay.portal.security.lang.DoPrivilegedHandler.invoke(DoPrivilegedHandler.java:56)
        at $Proxy483.findByG_P_L(Unknown Source)
        at com.liferay.portal.service.impl.LayoutLocalServiceImpl.getLayout(LayoutLocalServiceImpl.java:1011)
        at sun.reflect.GeneratedMethodAccessor1196.invoke(Unknown Source)
        at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        at java.lang.reflect.Method.invoke(Method.java:601)
        at com.liferay.portal.spring.aop.ServiceBeanMethodInvocation.proceed(ServiceBeanMethodInvocation.java:117)
        at com.liferay.portal.service.impl.LayoutLocalServiceVirtualLayoutsAdvice.invoke(LayoutLocalServiceVirtualLayoutsAdvice.java:83)
        at com.liferay.portal.spring.aop.ServiceBeanMethodInvocation.proceed(ServiceBeanMethodInvocation.java:113)
        at com.liferay.portal.service.impl.LayoutLocalServiceStagingAdvice.invoke(LayoutLocalServiceStagingAdvice.java:134)
        at com.liferay.portal.spring.aop.ServiceBeanMethodInvocation.proceed(ServiceBeanMethodInvocation.java:113)
        at com.liferay.portal.spring.transaction.DefaultTransactionExecutor.execute(DefaultTransactionExecutor.java:62)
        at com.liferay.portal.spring.transaction.TransactionInterceptor.invoke(TransactionInterceptor.java:52)
        at com.liferay.portal.spring.aop.ServiceBeanMethodInvocation.proceed(ServiceBeanMethodInvocation.java:113)
        at com.liferay.portal.spring.aop.ChainableMethodAdvice.invoke(ChainableMethodAdvice.java:56)
        at com.liferay.portal.spring.aop.ServiceBeanMethodInvocation.proceed(ServiceBeanMethodInvocation.java:113)
        at com.liferay.portal.spring.aop.ChainableMethodAdvice.invoke(ChainableMethodAdvice.java:56)
        at com.liferay.portal.spring.aop.ServiceBeanMethodInvocation.proceed(ServiceBeanMethodInvocation.java:113)
        at com.liferay.portal.spring.aop.ChainableMethodAdvice.invoke(ChainableMethodAdvice.java:56)
        at com.liferay.portal.spring.aop.ServiceBeanMethodInvocation.proceed(ServiceBeanMethodInvocation.java:113)
        at com.liferay.portal.spring.aop.ChainableMethodAdvice.invoke(ChainableMethodAdvice.java:56)
        at com.liferay.portal.spring.aop.ServiceBeanMethodInvocation.proceed(ServiceBeanMethodInvocation.java:113)
        at com.liferay.portal.spring.aop.ServiceBeanAopProxy.invoke(ServiceBeanAopProxy.java:218)
        at com.liferay.portal.security.pacl.PACLInvocationHandler.doInvoke(PACLInvocationHandler.java:62)
        at com.liferay.portal.security.pacl.PACLInvocationHandler.invoke(PACLInvocationHandler.java:51)
        at $Proxy107.getLayout(Unknown Source)
        at com.liferay.portal.service.LayoutLocalServiceUtil.getLayout(LayoutLocalServiceUtil.java:738)
        at com.liferay.so.hook.upgrade.v2_0_0.UpgradeAssetPublisher.doUpgrade(UpgradeAssetPublisher.java:60)
        at com.liferay.portal.kernel.upgrade.UpgradeProcess.upgrade(UpgradeProcess.java:178)
        ... 42 more
21:53:32,140 INFO  [localhost-startStop-3][HotDeployImpl:185] Deploying so-configurations-portlet from queue
21:53:32,141 INFO  [localhost-startStop-3][PluginPackageUtil:1049] Reading plugin package for so-configurations-portlet
Jul 17, 2013 9:53:32 PM org.apache.catalina.core.ApplicationContext log
INFO: Initializing Spring root WebApplicationContext

[Jonathan Lee]

I can actually reproduce this issue without creating a portal instance. This is actually quite a serious bug that existing since SO 2.0 and on. The cause is from the upgrade script in the old SO 1.6 which doesnt not apply to SO 2.0 anymore.

[Benjamin Yeh (Inactive)]

PASSED Manual Testing following the steps in the description.

Fixed on:
Tomcat 7.0.40 + MySQL 5. Portal 6.1.30 EE GA3
Plugins 6.1.x EE GIT ID: 0deff66333c9d44caece7e1b0ecd1928d16be3c0.

Tomcat 7.0.40 + MySQL 5. Portal 6.1.20 EE GA2
Plugins 6.1.x EE GIT ID: bd8f30b3b316603076e4980e0a2109e1503d7651.

Plugins deploys with no errors.