PUBLIC - Liferay Social Office Community Edition
  1. PUBLIC - Liferay Social Office Community Edition
  2. SOS-2042

Invite Members by email fails on account creation with active User workflow

    Details

    • Fix Priority:
      4
    • Affects Portal Version/s:
      6.1.20 EE GA2
    • Similar Issues:
      Show 5 results 
    • Portal Fix Version/s:
      6.2.0 CE GA1, 6.2.10 EE GA1

      Description

      Once a new site member has been invited by email, clicking the invitation link and submitting the filled Create Account form results in password error in UI. This occurs only when Kaleo is deployed and default workflow for Users is enabled.

      Reproduction steps:

      1. Set up outgoing mail server in Portal
      2. Deploy Kaleo, and set the default workflow for Users to Single Approver
      3. Create a Social Office site, and invite a new member by mail
      4. In the invitation email, click the link to confirm invitation
      5. Fill the registration form, and submit it
      6. Actual result: Error message appears telling about invalid password

      Expected result is to inform the user about the approval process with no error message. (As seen when one registers from the Portal's login portlet while User workflow is active.)

      With Portal 6.1.20, I found that getCreateAccountURL() (in MemberRequestLocalServiceImpl) appends a redirection paremeter to the invitation URL. After submitting the registration form, this takes the User to the Social Office site. But, with User workflow enabled, the new account is only halfway created before the approval, i.e. random password hasn't been generated. Since redirection into SO requires login and authentication, empty password raises an exception which results in the error message.

      As a solution, the invitation mail template could be changed to contain 2 separate links: one for account creation and one for login.

        Issue Links

          Activity

          Hide
          József Illés (Inactive) added a comment -

          Please find all the required portlets for trunk testing attached.

          Show
          József Illés (Inactive) added a comment - Please find all the required portlets for trunk testing attached.
          Hide
          József Illés (Inactive) added a comment - - edited

          For the record, the Pull Request was sent back to me since it couldn't be reproduced with these steps.

          Although it seems to work fine, I suspect that another issue hides the original error. Redirect URL's seemed to be cleared by the time it's processed by CreateAccountAction.

          Update: With the power of Git's bisect, the offending commit turned out to be 5bcfcbe from LPS-35309. This enforces the use of namespaces in parameters.

          Show
          József Illés (Inactive) added a comment - - edited For the record, the Pull Request was sent back to me since it couldn't be reproduced with these steps. Although it seems to work fine, I suspect that another issue hides the original error. Redirect URL's seemed to be cleared by the time it's processed by CreateAccountAction. Update: With the power of Git's bisect, the offending commit turned out to be 5bcfcbe from LPS-35309 . This enforces the use of namespaces in parameters.
          Hide
          József Illés (Inactive) added a comment -

          Hey Tamas,

          could you please check this out tomorrow?

          I aggregated all the related SOS tickets in one pull request.

          Although key parameter doesn't seem to be used, proper namespace is needed for it to be visible. I check it with a modified JSP locally. That's why I didn't remove the method itself.

          Show
          József Illés (Inactive) added a comment - Hey Tamas, could you please check this out tomorrow? I aggregated all the related SOS tickets in one pull request. Although key parameter doesn't seem to be used, proper namespace is needed for it to be visible. I check it with a modified JSP locally. That's why I didn't remove the method itself.
          Hide
          Ken Duenwald added a comment -

          PASSED Manual Testing following the steps in the description.

          Fixed on:
          Tomcat 7.0.42 + MySQL 5. Portal 6.2.0 CE GA1.
          Plugins 6.2.x CE GIT ID: d1956d0f4097ebfafa7787e79ab274afd586a1ac.
          Tomcat 7.0.42 + MySQL 5. Portal 6.2.10 EE GA1.
          Plugins 6.2.x EE GIT ID: da5ba027a6b804c11b4498ce27ce2363259fd6d2.

          There is no longer an error message at step 6.

          Show
          Ken Duenwald added a comment - PASSED Manual Testing following the steps in the description. Fixed on: Tomcat 7.0.42 + MySQL 5. Portal 6.2.0 CE GA1. Plugins 6.2.x CE GIT ID: d1956d0f4097ebfafa7787e79ab274afd586a1ac. Tomcat 7.0.42 + MySQL 5. Portal 6.2.10 EE GA1. Plugins 6.2.x EE GIT ID: da5ba027a6b804c11b4498ce27ce2363259fd6d2. There is no longer an error message at step 6.

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Date of First Response:
                Days since last comment:
                1 year, 6 weeks, 1 day ago

                Development

                  Structure Helper Panel