UpgradeBookmarks from SO upgrade is not scalable

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 3.X EE, 3.X CE
• Fix Version/s: 3.X CE, 3.0.1 EE, 3.1.0 CE
• Component/s: Social Office Site, Social Office Site > Bookmarks
• Labels: None
• Fix Priority: 5

UpgradeBookmarks grabs every single group, then grabs every single layoutSet and bookmarksFolder associated with it. It's very inefficient and will not scale with large number of groups.

[Mandy Lee (Inactive)]

PASSED Manual Testing using the following steps:

1. Start portal without SO.
2. Create 50,000 sites.
3. Deploy SO plugins.
4. Verify that registering and upgrade works with no errors.

Console should be clean and look something like this:

23:22:59,633 INFO  [localhost-startStop-4][HookHotDeployListener:687] Registering hook for so-hook
Loading file:/D:/6.2.0/liferay-portal-6.2.0-ce-ga1/tomcat-7.0.42/temp/15-so-hook/WEB-INF/classes/portal.properties
23:22:59,648 INFO  [localhost-startStop-4][UpgradeProcess:175] Upgrading com.liferay.so.hook.upgrade.UpgradeProcess_2_0_2
23:22:59,649 INFO  [localhost-startStop-4][UpgradeProcess:175] Upgrading com.liferay.so.hook.upgrade.v2_0_2.UpgradeCompany
23:23:02,867 INFO  [localhost-startStop-4][UpgradeProcess:175] Upgrading com.liferay.so.hook.upgrade.v2_0_2.UpgradeUser
23:23:02,872 INFO  [localhost-startStop-4][UpgradeProcess:175] Upgrading com.liferay.so.hook.upgrade.v2_0_2.UpgradeGroup
23:23:58,315 INFO  [localhost-startStop-4][UpgradeProcess:175] Upgrading com.liferay.so.hook.upgrade.UpgradeProcess_2_0_3
23:23:58,317 INFO  [localhost-startStop-4][UpgradeProcess:175] Upgrading com.liferay.so.hook.upgrade.v2_0_3.UpgradeBookmarks
23:23:58,326 INFO  [localhost-startStop-4][UpgradeProcess:175] Upgrading com.liferay.so.hook.upgrade.UpgradeProcess_2_0_4
23:23:58,327 INFO  [localhost-startStop-4][UpgradeProcess:175] Upgrading com.liferay.so.hook.upgrade.v2_0_4.UpgradeLayout
23:23:58,328 INFO  [localhost-startStop-4][UpgradeProcess:175] Upgrading com.liferay.so.hook.upgrade.v2_0_4.UpgradeLayoutSet
23:23:58,330 INFO  [localhost-startStop-4][UpgradeProcess:175] Upgrading com.liferay.so.hook.upgrade.v2_0_4.UpgradeTheme
23:23:58,332 INFO  [localhost-startStop-4][UpgradeProcess:175] Upgrading com.liferay.so.hook.upgrade.UpgradeProcess_3_0_0
23:23:58,334 INFO  [localhost-startStop-4][UpgradeProcess:175] Upgrading com.liferay.so.hook.upgrade.v3_0_0.UpgradeLayoutSetPrototype
23:23:58,392 INFO  [localhost-startStop-4][UpgradeProcess:175] Upgrading com.liferay.so.hook.upgrade.v3_0_0.UpgradeDocumentLibrary
23:23:58,394 INFO  [localhost-startStop-4][UpgradeProcess:175] Upgrading com.liferay.so.hook.upgrade.v3_0_0.UpgradeGroup
23:24:22,884 INFO  [localhost-startStop-4][UpgradeProcess:175] Upgrading com.liferay.so.hook.upgrade.v3_0_0.UpgradeLayout
23:24:22,957 INFO  [localhost-startStop-4][HookHotDeployListener:814] Hook for so-hook is available for use
23:24:22,958 INFO  [localhost-startStop-4][HotDeployImpl:195] Deploying so-configurations-portlet from queue
23:24:22,959 INFO  [localhost-startStop-4][PluginPackageUtil:1016] Reading plugin package for so-configurations-portlet
Mar 21, 2014 11:24:23 PM org.apache.catalina.core.ApplicationContext log
INFO: Initializing Spring root WebApplicationContext
23:24:23,094 INFO  [localhost-startStop-4][HookHotDeployListener:687] Registering hook for so-configurations-portlet
Loading file:/D:/6.2.0/liferay-portal-6.2.0-ce-ga1/tomcat-7.0.42/temp/14-so-configurations-portlet/WEB-INF/classes/portal.properties
23:24:23,099 INFO  [localhost-startStop-4][HookHotDeployListener:814] Hook for so-configurations-portlet is available for use
23:24:23,101 INFO  [localhost-startStop-4][PortletHotDeployListener:343] Registering portlets for so-configurations-portlet
23:24:23,174 INFO  [localhost-startStop-4][PortletHotDeployListener:490] 1 portlet for so-configurations-portlet is available for use

Fixed on:
Tomcat 7 + MySQL 5. Portal 6.2.0 CE GA1.
Plugins 6.2.X CE Git ID: 32b06d22cdb645b1aeb0d5ee0a7e86cac3d38582.

Tomcat 7 + MySQL 5. Portal 6.2.10 EE GA1.
Plugins 6.2.X EE Git ID: 743b4766c0e11cce6b7ecd1e21eb71683449d78f.